[PATCH] D110186: Fix tests defaulting to incorrect triples on AIX

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 27 07:13:49 PDT 2021


jsji added a comment.

In D110186#3024498 <https://reviews.llvm.org/D110186#3024498>, @jrtc27 wrote:

> In D110186#3024483 <https://reviews.llvm.org/D110186#3024483>, @jsji wrote:
>
>>> they will by definition have host-dependent behaviour.
>>
>> Yes,  that is why I am asking to update the host (*AIX*) default behaviors for those arch we don't support -- we don't have to default to XCOFF for those arch on AIX.
>
> My point is this is the correct way to fix these broken tests; you were saying this was not a good way to fix it.

:),  you are right. I agree that this is the correct way.  
I just want to make sure we also update our host default behaviors so that we don't have to pay the additional maintenance efforts for future testcases for other targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110186/new/

https://reviews.llvm.org/D110186



More information about the llvm-commits mailing list