[PATCH] D106056: [CVP] processSwitch: Remove default case when switch cover all possible values.

JunMa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 27 02:14:13 PDT 2021


junparser added a comment.

In D106056#3023777 <https://reviews.llvm.org/D106056#3023777>, @xbolva00 wrote:

> In D106056#3023709 <https://reviews.llvm.org/D106056#3023709>, @alexfh wrote:
>
>> We'd appreciate a prompt fix or a workaround. If neither is possible, please revert the commit while working on a proper solution.
>
> Well, it is not "common" code, switch 1000 cases. But easy fix is probably to introduce some reasonable limit when to bail out.



In D106056#3023777 <https://reviews.llvm.org/D106056#3023777>, @xbolva00 wrote:

> In D106056#3023709 <https://reviews.llvm.org/D106056#3023709>, @alexfh wrote:
>
>> We'd appreciate a prompt fix or a workaround. If neither is possible, please revert the commit while working on a proper solution.
>
> Well, it is not "common" code, switch 1000 cases. But easy fix is probably to introduce some reasonable limit when to bail out.

switch 1000 cases is not the issue, use loop induction variable as condition is.  It cause LVI recursive call SolveBlockValue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106056/new/

https://reviews.llvm.org/D106056



More information about the llvm-commits mailing list