[PATCH] D110467: [ISEL] Legalize arithmetic.fence.f128 for 32-bits target

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 27 01:58:23 PDT 2021


xiangzhangllvm marked an inline comment as done.
xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:212-214
+  SDValue NewFence = DAG.getNode(ISD::ARITH_FENCE, SDLoc(N), Ty,
+                                 GetSoftenedFloat(N->getOperand(0)));
+  return NewFence;
----------------
pengfei wrote:
> Nit: We can return it directly.
Yes, seems no affect, let it be (at least easy for debug). : )


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110467/new/

https://reviews.llvm.org/D110467



More information about the llvm-commits mailing list