[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols
    Matt Arsenault via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Sep 23 10:06:09 PDT 2021
    
    
  
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:65
 
-  return cast<Function>(Op.getGlobal());
+  return dyn_cast<Function>(Op.getGlobal());
 }
----------------
gandhi21299 wrote:
> arsenm wrote:
> > I think this is not the right place for this. If we can determine the callee function, we should have directly set it in the instruction during call lowering
> Which file would that be in?
SIISelLowering and AMDGPUCallLowering
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109707/new/
https://reviews.llvm.org/D109707
    
    
More information about the llvm-commits
mailing list