[PATCH] D106408: Allow rematerialization of virtual reg uses

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetInstrInfo.cpp:990
-    // is not necessarily a good idea, certainly not "trivial".
-    if (MO.isUse())
-      return false;
----------------
The comments looks reasonable to me. The use register's live range is extended if we rematerialize def register. Removing this code is not friendly to RA. Do you have any data  to ensure there is no side effect but benefit by removing this code?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106408/new/

https://reviews.llvm.org/D106408