[PATCH] D110466: [llvm-profgen][CSSPGO] On-demand function size computation for preinliner

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:430
+  if (Binary->getTrackFuncContextSize())
+    computeFuncSizeForSampleHitFunction();
+
----------------
Can this be done when preinliner is enabled?


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:447
+      uint64_t RangeStartOffset = Item.first.first;
+      auto FuncRange = Binary->findFuncOffsetRange(RangeStartOffset);
+      if (FuncRange.second != 0)
----------------
Does this include ranges not executed? Those ranges should also be counted for size calculation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110466/new/

https://reviews.llvm.org/D110466