[PATCH] D110491: [Polly] Check the properties of accesses to operands of a matrix-matrix multiplication

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 26 17:26:48 PDT 2021


Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

Thanks for the patch. I have one concern with the the regression test: A single `CHECK-NOT` test is not a robust test to check anything, the test would succeed even if nothing is printed at all.

I am still accepting the patch in the interest of getting this fixed. However, I may replace the test by something else, e.g. by checking that the output with and without the flag is the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110491/new/

https://reviews.llvm.org/D110491



More information about the llvm-commits mailing list