[PATCH] D110312: [X86][ISel] setOperationAction for FROUND(f16) and FROUNDEVEN(f16)
Pengfei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 26 01:24:39 PDT 2021
pengfei added inline comments.
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:22503
static SDValue LowerFROUND(SDValue Op, SelectionDAG &DAG) {
+ if (Op.getOpcode() == ISD::STRICT_FROUND &&
+ Op.getSimpleValueType() == MVT::f16)
----------------
FreddyYe wrote:
> pengfei wrote:
> > Can we customize `STRICT_FROUND` here too? I think you just need to chain the FP nodes togerther.
> @craig.topper created this function originally. He mentions
>
> > Constrained intrinsics would use STRICT_FROUND which won't go through this code.
>
> at https://reviews.llvm.org/D73607. Hi Craig, can we chain the FP nodes here?
Oh, I see. Can we return SDValue() so that we can call lib function finally?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110312/new/
https://reviews.llvm.org/D110312
More information about the llvm-commits
mailing list