[PATCH] D110388: [SelectionDAG] Make WidenVecRes_SELECT work for scalable vectors

[eric tang via Phabricator via llvm-commits]

tangxingxin1008 added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-select.ll:213
 
 define <vscale x 2 x i64> @sel_nxv2i64(<vscale x 2 x i1> %p, <vscale x 2 x i64> %dst, <vscale x 2 x i64> %a) {
 ; CHECK-LABEL: sel_nxv2i64:
----------------
david-arm wrote:
> Would you mind also adding a test for the case when the condition is a vector that needs widening, i.e.
> 
>   %sel = select <vscale x 1 x i1> %p, <vscale x 1 x i64> %a, <vscale x 1 x i64> %dst
>   ret <vscale x 1 x i64> %sel
Addressed your comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110388/new/

https://reviews.llvm.org/D110388