[llvm] e21b0ba - [ADT] Add trailing comma on TYPED_TEST_SUITE

Alexandre Rames via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 25 18:04:25 PDT 2021


Author: Alexandre Rames
Date: 2021-09-25T18:04:16-07:00
New Revision: e21b0ba8c9378bca01d2311be4e1b6ccd3397bc4

URL: https://github.com/llvm/llvm-project/commit/e21b0ba8c9378bca01d2311be4e1b6ccd3397bc4
DIFF: https://github.com/llvm/llvm-project/commit/e21b0ba8c9378bca01d2311be4e1b6ccd3397bc4.diff

LOG: [ADT]  Add trailing comma on TYPED_TEST_SUITE

This avoids a -pedantic warning:
warning: ISO C++11 requires at least one argument for the "..." in a variadic macro

See also https://github.com/google/googletest/issues/2271

Reviewed By: arames, bkramer

Differential Revision: https://reviews.llvm.org/D110283

Added: 
    

Modified: 
    llvm/unittests/ADT/SequenceTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/ADT/SequenceTest.cpp b/llvm/unittests/ADT/SequenceTest.cpp
index 4ed54f1589d05..8ac1e208a946c 100644
--- a/llvm/unittests/ADT/SequenceTest.cpp
+++ b/llvm/unittests/ADT/SequenceTest.cpp
@@ -35,7 +35,7 @@ using IntegralTypes = testing::Types<uint8_t,   // 0
                                      >;
 
 template <class T> class StrongIntTest : public testing::Test {};
-TYPED_TEST_SUITE(StrongIntTest, IntegralTypes);
+TYPED_TEST_SUITE(StrongIntTest, IntegralTypes, );
 TYPED_TEST(StrongIntTest, Operations) {
   using T = TypeParam;
   auto Max = std::numeric_limits<T>::max();


        


More information about the llvm-commits mailing list