[PATCH] D110413: [X86] Fix handling of i128<->fp on Windows

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D110413#3022582 <https://reviews.llvm.org/D110413#3022582>, @vtjnash wrote:

> Looks similar to my previous patch (rG4a406d32e97b1748c4eed6674a2c1819b9cf98ea <https://reviews.llvm.org/rG4a406d32e97b1748c4eed6674a2c1819b9cf98ea>), so this makes sense to me.
>
>> X86CallingConv.td doesn't seem to handle i128 at all
>
> Looking at the commit history, it seems like I tried that, but that since i128 was removed by the legalizer, it was not feasible:
> https://reviews.llvm.org/D1998#37285

Oh, thanks for that context! (I didn't find the corresponding phabricator review for that patch as it wasn't mentioned in the commit message.) That makes it even clearer that we indeed probably need to do it this way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110413/new/

https://reviews.llvm.org/D110413