[PATCH] D109443: [LV] Lazy creation of runtime checks
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Sep 25 12:09:36 PDT 2021
fhahn added a comment.
> Also this facilitates future development.
Could you provide a few more details on this, i.e. what the drawbacks of explicit initialization are? Personally I find the code easier to follow if things happen explicitly. Are you anticipating the need to generate the runtime checks at different points?
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:10052
+ GeneratedRTChecks RTChecks(PSE, *LVL, DT, LI, L,
+ F->getParent()->getDataLayout());
----------------
Do this need to be moved?
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:10288
+ GeneratedRTChecks RTChecks(PSE, LVL, DT, LI, L,
+ F->getParent()->getDataLayout());
----------------
does this need to be moved?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109443/new/
https://reviews.llvm.org/D109443
More information about the llvm-commits
mailing list