[PATCH] D110475: [LLVM][IR] Resolve Verifier FIXME: remove if (V->isArtificial()) check

[Alf via Phabricator via llvm-commits]

gAlfonso-bit created this revision.
gAlfonso-bit added reviewers: jeroen.dobbelaere, dexonsmith, jdoerfert.
Herald added a subscriber: hiraditya.
gAlfonso-bit requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The FIXME is no longer relevant, so let's remove it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110475

Files:
  llvm/lib/IR/Verifier.cpp


Index: llvm/lib/IR/Verifier.cpp
===================================================================
--- llvm/lib/IR/Verifier.cpp
+++ llvm/lib/IR/Verifier.cpp
@@ -5599,15 +5599,6 @@
   if (!Fragment)
     return;
 
-  // The frontend helps out GDB by emitting the members of local anonymous
-  // unions as artificial local variables with shared storage. When SROA splits
-  // the storage for artificial local variables that are smaller than the entire
-  // union, the overhang piece will be outside of the allotted space for the
-  // variable and this check fails.
-  // FIXME: Remove this check as soon as clang stops doing this; it hides bugs.
-  if (V->isArtificial())
-    return;
-
   verifyFragmentExpression(*V, *Fragment, &I);
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110475.375033.patch
Type: text/x-patch
Size: 743 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210925/2566542f/attachment.bin>