[PATCH] D110464: [lld-macho][nfc] Added some notes on deliberate differences btw LLD vs LD64

Fri Sep 24 21:39:50 PDT 2021

thevinster added inline comments.

================
Comment at: lld/MachO/notes.txt:1
+This docs is the running list of significant differences in behaviour between LD64 and LLD-MachO.
+
----------------
I presume these are differences in ld64 that we don't want to replicate in LLD? If so, I think it might be good to reflect something around those lines to not confuse the reader that this is some sort of todo list for LLD. 

================
Comment at: lld/MachO/notes.txt:5
+  - General resolution rule:
+    + LD64: the "winning" symbols are chosen based on several criteria.
+    + LLD:  metadata from symbols with the same are merged, and the content of
----------------
It might seem more useful if we clarify what those criteria are?

================
Comment at: lld/MachO/notes.txt:6-7
+    + LD64: the "winning" symbols are chosen based on several criteria.
+    + LLD:  metadata from symbols with the same are merged, and the content of
+               the first symbol in the symbol table  with that name is kept.
+  
----------------

================
Comment at: lld/MachO/notes.txt:11
+    + LD64:
+      * Duplicate ObjC symbols from the same arhives are fine. It will pick the first one.
+      * Duplicate ObjC symbols from different archives will raise a "duplicate symbol" error.
----------------

================
Comment at: lld/MachO/notes.txt:15
+
+  - Handling of personality symbols
+
----------------
Are you planning to continue this section here?

================
Comment at: lld/MachO/notes.txt:18
+
+// FIXME: There's something to say about section alignment. I forgot...
----------------
If we're planning to check this in, it might seem best to leave FIXME's out of notes. It's not code and you could always add this in when you remember. :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110464/new/

https://reviews.llvm.org/D110464