[PATCH] D110449: [llvm-profdata] Extend support of --topn to sample profiles

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 24 16:37:52 PDT 2021


wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

lgtm with a nit, thanks.



================
Comment at: llvm/test/tools/llvm-profdata/sample-topn.test:1
+; RUN: llvm-profdata show --sample --topn=2 %S/Inputs/sample-hot-func-list.proftext | FileCheck %s --match-full-lines --strict-whitespace --check-prefix=TOPN
+
----------------
I think it's better to merge the tests into sample-hot-func-list.test. This is improving hot func list and the tests also use the same inputs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110449/new/

https://reviews.llvm.org/D110449



More information about the llvm-commits mailing list