[PATCH] D110055: [AsmPrinter] Loop over bundles in generic code

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 24 13:35:41 PDT 2021


arsenm added a comment.

I think letting generic code inspect individual instructions inside bundles violates the spirit of what bundles, which should generally be opaque to generic code. I wouldn't be surprised if this breaks some out of tree target using bundles



================
Comment at: llvm/lib/Target/Hexagon/HexagonAsmPrinter.cpp:761
+    return;
   } else {
     HexagonLowerToMC(MCII, MI, MCB, *this);
----------------
No else after return


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110055/new/

https://reviews.llvm.org/D110055



More information about the llvm-commits mailing list