[PATCH] D110443: [dsymutil] Track incompleteness across unions

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere created this revision.
JDevlieghere added a reviewer: friss.
Herald added a subscriber: hiraditya.
JDevlieghere requested review of this revision.
Herald added a project: LLVM.

When determining the incompleteness of a DIE based on its children, make sure we propagate it  across union types. See test case for an example. Without this patch we never emit the definition of `Container_ivars`.


https://reviews.llvm.org/D110443

Files:
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/test/tools/dsymutil/Inputs/private/tmp/union/a.out
  llvm/test/tools/dsymutil/Inputs/private/tmp/union/container.o
  llvm/test/tools/dsymutil/Inputs/private/tmp/union/use.o
  llvm/test/tools/dsymutil/X86/union-fwd-decl.test


Index: llvm/test/tools/dsymutil/X86/union-fwd-decl.test
===================================================================
--- /dev/null
+++ llvm/test/tools/dsymutil/X86/union-fwd-decl.test
@@ -0,0 +1,61 @@
+Test binaries created with the following commands:
+
+$ cat container.cpp
+#include "container.h"
+#include <stdlib.h>
+
+struct Container_ivars {
+  // real definition here
+};
+
+ContainerPtr allocateContainer() {
+  Container *c = (Container *)malloc(sizeof(Container));
+  c->ivars = (Container_ivars *)malloc(sizeof(Container_ivars));
+  return c;
+}
+
+extern void doSomething(ContainerPtr);
+
+int main() {
+  ContainerPtr c = allocateContainer();
+  doSomething(c);
+  return 0;
+}
+
+$ cat container.h
+struct Container_ivars;
+
+struct Container {
+  union {
+    struct Container_ivars *ivars;
+  };
+};
+
+typedef Container *ContainerPtr;
+
+$ cat use.cpp
+#include "container.h"
+
+void doSomething(ContainerPtr c) {}
+
+
+$ clang++ -O0 -g container.cpp -c -o container.o
+$ clang++ -O0 -g use.cpp -c -o use.o
+$ clang++ use.o container.o -o a.out
+
+Note that the link order in the last command matters for this test.
+
+RUN: dsymutil -oso-prepend-path %p/../Inputs %p/../Inputs/private/tmp/union/a.out -o %t.dSYM
+RUN: llvm-dwarfdump %t.dSYM | FileCheck %s
+
+CHECK: DW_TAG_compile_unit
+
+CHECK:          DW_AT_name      ("Container_ivars")
+CHECK-NEXT:     DW_AT_declaration       (true)
+
+CHECK: DW_TAG_compile_unit
+
+CHECK:          DW_AT_name      ("Container_ivars")
+CHECK-NEXT:     DW_AT_byte_size (0x01)
+CHECK-NEXT:     DW_AT_decl_file ("/tmp/union/container.cpp")
+CHECK-NEXT:     DW_AT_decl_line (4)
Index: llvm/lib/DWARFLinker/DWARFLinker.cpp
===================================================================
--- llvm/lib/DWARFLinker/DWARFLinker.cpp
+++ llvm/lib/DWARFLinker/DWARFLinker.cpp
@@ -549,6 +549,7 @@
   switch (Die.getTag()) {
   case dwarf::DW_TAG_structure_type:
   case dwarf::DW_TAG_class_type:
+  case dwarf::DW_TAG_union_type:
     break;
   default:
     return;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110443.374942.patch
Type: text/x-patch
Size: 2022 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210924/62cb8734/attachment.bin>