[PATCH] D110299: Add subrange debugging for languages that support native subrange types

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

I think this looks generally reasonable.

Is my understanding correctly that this is in support of types like Pascals `type subrange : 1..10`?

Can you add llvm-as/dis  round-trip tests to test/Assembler?
I don't see a test for the DIExpression bounds case?



================
Comment at: llvm/test/DebugInfo/X86/subrange.ll:6
+
+; ModuleID = 'Main.mb'
+source_filename = "../src/Main.m3"
----------------
Would you mind also including the source code in a comment? It might helps reading the testcase's metadata.


================
Comment at: llvm/test/Verifier/subrange.ll:23
+  call void @llvm.dbg.declare(metadata i32* %l, metadata !31, metadata !DIExpression()), !dbg !25
+  call void @llvm.dbg.declare(metadata %struct.0* %ar, metadata !34, metadata !DIExpression()), !dbg !25
+  store i64 0, i64* %tmp.9, align 8, !dbg !38
----------------
This test looks like it could be reduced quite a bit and it probably doesn't even need any code at all. You can take a look at other verifier tests for examples.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110299/new/

https://reviews.llvm.org/D110299