[PATCH] D110165: [DebugInfo][NFC] Move LiveDebugValues class declaration to a header, add unit test boilerplate

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 24 11:05:01 PDT 2021


aprantl added a comment.

Apart from missing clang-format this patch seems fine to me.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:40
+
+// XXX XXX XXX docs
+class LocIdx {
----------------
?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:121
+public:
+  // XXX -- temporarily enabled while the live-in / live-out tables are moved
+  // to something more type-y
----------------
?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110165/new/

https://reviews.llvm.org/D110165



More information about the llvm-commits mailing list