[PATCH] D110112: [IR]PATCH 1/2: Add AsmWriterContext into AsmWriter

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 24 11:01:57 PDT 2021


aprantl added a comment.

Seems reasonable.



================
Comment at: llvm/lib/IR/AsmWriter.cpp:1282
+namespace {
+struct AsmWriterContext {
+  TypePrinting *TypePrinter;
----------------
Can you add a Doxygen comment?


================
Comment at: llvm/lib/IR/AsmWriter.cpp:1284
+  TypePrinting *TypePrinter;
+  SlotTracker *Machine;
+  const Module *Context;
----------------
` = nullptr;` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110112/new/

https://reviews.llvm.org/D110112



More information about the llvm-commits mailing list