[PATCH] D110419: [TargetLibraryInfo] Pick new/delete calls by target

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 24 10:47:07 PDT 2021


rnk added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/malloc-free-delete.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -instcombine -S | FileCheck %s
+; RUN: opt < %s -mtriple x86_64--linux -instcombine -S | FileCheck %s
+; RUN: opt < %s -mtriple x86_64--windows -instcombine -S | FileCheck %s --check-prefix=WINDOWS
----------------
For the C APIs (malloc, calloc, free), I would like this test to remain target-neutral. Do you mind splitting it into malloc-free.ll, new-delete-itanium.ll, new-delete-msvc.ll? The second two get triples, the first retains the C-only parts of the test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110419/new/

https://reviews.llvm.org/D110419



More information about the llvm-commits mailing list