[PATCH] D110422: [AIX] Enable PGO without LTO

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 24 09:26:32 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:978
   if (NS == 0 && !(DataReferencedByCode && NeedComdat && !Renamed) &&
-      (TT.isOSBinFormatELF() ||
+      (TT.isOSBinFormatELF() || TT.isOSBinFormatXCOFF() ||
        (!DataReferencedByCode && TT.isOSBinFormatCOFF()))) {
----------------
This place is for binary formats which can properly GC metadata sections. If XCOFF can't, it shouldn't be added here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110422/new/

https://reviews.llvm.org/D110422



More information about the llvm-commits mailing list