[PATCH] D109844: [DSE] Track earliest escape, use for loads in isReadClobber.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 24 09:15:44 PDT 2021
fhahn added a comment.
In D109844#3020675 <https://reviews.llvm.org/D109844#3020675>, @thakis wrote:
> Reduced repro: https://bugs.chromium.org/p/chromium/issues/detail?id=1252762#c6
>
> Reverted in df56fc6ebbe <https://reviews.llvm.org/rGdf56fc6ebbee6c458b0473185277b7860f7e3408> for now.
Thanks for the report! The issue was that the earliest escape was a `ptrtoint` which gets removed later. The code to invalidate the cached earliest escape only considered removed memory instructions. I recommitted the patch in 6f28fb708149 <https://reviews.llvm.org/rG6f28fb708149e9db8d077e65fcc9f87d566e824a> with a fix to check whether we need to invalidate the cache for any deleted instruction.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109844/new/
https://reviews.llvm.org/D109844
More information about the llvm-commits
mailing list