[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 24 08:51:50 PDT 2021


lei accepted this revision as: lei.
lei added a comment.

LGTM
Pleases address nit on commit.



================
Comment at: clang/lib/Sema/SemaChecking.cpp:3495-3496
+        ArgType != QualType(Context.DoubleTy)) {
+      Diag(TheCall->getBeginLoc(), diag::err_ppc_invalid_test_data_class_type);
+      return true;
+    }
----------------
nit: I think these 2 stmts can just be merged into `return Diag(....);` and brace removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109437/new/

https://reviews.llvm.org/D109437



More information about the llvm-commits mailing list