[PATCH] D109148: [DAGCombiner][VP] Fold zero-length or false-masked VP ops

Fri Sep 24 08:03:30 PDT 2021

frasercrmck marked an inline comment as done.
frasercrmck added a comment.

In D109148#3020272 <https://reviews.llvm.org/D109148#3020272>, @simoll wrote:

> LGTM. We should cleanup the `VPIntrinsics.def` file some time .. originally every property was attached to //some// entity (intrinsic and/or sdnode) by placing the property macro in the scope of the entity. Now, we are seeing the ID being repeated in the property macros, making it independent of the scope. Let's discuss this on the call. This should not hold back the patch.

Makes sense, let's discuss.

I'll need someone's official acceptance before I can merge this patch. I'll also get round to doing the same thing in InstSimplify some time.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109148/new/

https://reviews.llvm.org/D109148