[PATCH] D110342: [x86] convert logic-of-FP-compares to FP logic-of-vector-compares

Fri Sep 24 05:36:37 PDT 2021

pengfei accepted this revision.
pengfei added a comment.

LGTM.

================
Comment at: llvm/test/CodeGen/X86/fcmp-logic.ll:242-258
 ; SSE2-LABEL: olt_olt_and_f32_f64:
 ; SSE2:       # %bb.0:
 ; SSE2-NEXT:    ucomiss %xmm0, %xmm1
 ; SSE2-NEXT:    seta %cl
 ; SSE2-NEXT:    ucomisd %xmm2, %xmm3
 ; SSE2-NEXT:    seta %al
 ; SSE2-NEXT:    andb %cl, %al
----------------
spatel wrote:
> pengfei wrote:
> > Should we add a common `CHECK` for them?
> It's the "v" in the mnemonics that makes these different. Do we have a scrubber option in the script for that?
Oh, yes. I don't think there's such an option. I did have the same thought. But I think it's not easy to achieve. It's valuable only when we check SSE and AVX instructions at the same time. Omitting 'v' unconditionally is over kill.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110342/new/

https://reviews.llvm.org/D110342