[PATCH] D110350: [llvm-objcopy][NFC] Add a helper method RelocationSectionBase::getPrefix()

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 24 00:05:27 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one suggestion.



================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.h:748
 
+  StringRef getPrefix() const;
+
----------------
Perhaps `getNamePrefix` for complete clarity on the function's purpose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110350/new/

https://reviews.llvm.org/D110350



More information about the llvm-commits mailing list