[PATCH] D110320: [XCOFF] refactor error reporting.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added a comment.

The code change generally looks good to me. But please make the error messages consistent, see my inline comments.



================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/relocations-invalid.test:26
 # INVALID-SYM-NEXT:   Section (index: 1) .text {
-# INVALID-SYM-NEXT:     warning: '[[FILE]]': Invalid symbol index
+# INVALID-SYM-NEXT:     warning: '[[FILE]]': symbol index 33 exceeds symbol number 0
 # INVALID-SYM-NEXT:   }
----------------



================
Comment at: llvm/test/tools/obj2yaml/XCOFF/invalid-symbol.yaml:8
 
-# ERROR1: Invalid section index
+# ERROR1: the section index (2) is invalid
 
----------------



================
Comment at: llvm/test/tools/obj2yaml/XCOFF/invalid-symbol.yaml:22
 
-# ERROR2: Invalid data was encountered while parsing the file
+# ERROR2: entry with offset 0x4 in a string table with size 0x4 is invalid
 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110320/new/

https://reviews.llvm.org/D110320