[PATCH] D110277: [compiler-rt][profile] Account for binary IDs size in test

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 23 14:23:40 PDT 2021


phosek added a comment.

I'd prefer including `profile/InstrProfData.inc` and using types rather than just hardcoding the offsets. In the past, some fields have already moved around (for example between version 6 and 7 binary IDs size has moved). If this happens again, this test would break. Using types should be less error prone and more readable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110277/new/

https://reviews.llvm.org/D110277



More information about the llvm-commits mailing list