[PATCH] D110342: [x86] convert logic-of-FP-compares to FP logic-of-vector-compares

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked 3 inline comments as done.
spatel added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:45511
+  SDValue InsN11 =
+      DAG.getNode(ISD::INSERT_VECTOR_ELT, DL, VecVT, BaseVec, N11, ZeroIndex);
+  SDValue Setcc0 = DAG.getSetCC(DL, BoolVecVT, InsN00, InsN01,
----------------
RKSimon wrote:
> Why not use SCALAR_TO_VECTOR ?
No reason - forgot we had that opcode.


================
Comment at: llvm/test/CodeGen/X86/fcmp-logic.ll:155
 
+; This uses ucomis because the types do not match.
+
----------------
RKSimon wrote:
> These could still be merged (as long as we only use the lower 32-bits).?
Yes - we'd need to add a cast to make it work, but hopefully that would get folded away at some point.
I'll add a TODO for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110342/new/

https://reviews.llvm.org/D110342