[PATCH] D110053: [AMDGPU] Add a regclass flag for scalar registers

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 23 11:21:04 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.td:138
+  // TODO: This flag is currently set for all regclasses other than vectors.
+  // Some of them aren't truly GPRs, TTMP for instance. It won't be a problem
+  // as long as they remain unallocatable.
----------------
cdevadas wrote:
> rampitec wrote:
> > TTMP is scalar.
> I will use another reference.
I think you can just drop the comment. There does not seem to be a TODO here.
Otherwise LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110053/new/

https://reviews.llvm.org/D110053



More information about the llvm-commits mailing list