[PATCH] D110336: [X86][FP16] Add more builtins to avoid multi evaluation problems & add 2 missed intrinsics
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 23 11:12:38 PDT 2021
craig.topper added inline comments.
================
Comment at: clang/include/clang/Basic/BuiltinsX86.def:2021
TARGET_BUILTIN(__builtin_ia32_vfmaddcph256_maskz, "V8fV8fV8fV8fUc", "ncV:256:", "avx512fp16,avx512vl")
-TARGET_BUILTIN(__builtin_ia32_vfmaddcph512_mask, "V16fV16fV16fV16fUsIi", "ncV:512:", "avx512fp16")
+TARGET_BUILTIN(__builtin_ia32_vfmaddcph512_mask, "V16fV16fUsV16fV16fIi", "ncV:512:", "avx512fp16")
TARGET_BUILTIN(__builtin_ia32_vfmaddcph512_maskz, "V16fV16fV16fV16fUsIi", "ncV:512:", "avx512fp16")
----------------
Why move the mask? Its always the last or second to last operand on most if not all builtins.
================
Comment at: clang/lib/Headers/avx512fp16intrin.h:3003
+static __inline__ __m128h __DEFAULT_FN_ATTRS128
+_mm_mask3_fmadd_sch(__m128h __A, __m128h __B, __m128h __C, __mmask8 __U) {
+ return (__m128h)__builtin_ia32_vfmaddcsh_round_mask3(
----------------
This isn't in the intrinsics guide.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110336/new/
https://reviews.llvm.org/D110336
More information about the llvm-commits
mailing list