[PATCH] D110188: [compiler-rt][profile] Add padding after binary IDs

Thu Sep 23 10:28:23 PDT 2021

leonardchan added a comment.

In D110188#3016917 <https://reviews.llvm.org/D110188#3016917>, @gulfem wrote:

> Thanks for the fix @leonardchan 
> Other type of paddings are added in:
> https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/profile/InstrProfilingBuffer.c#L86
>
> Do you think we can follow the same pattern?

That could work, but I think that would mean needing to call `__llvm_profile_get_padding_sizes_for_counters` after each instance we call `__llvm_write_binary_ids` when we instead could just pack it in `__llvm_write_binary_ids`. I imagine this is much simpler.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110188/new/

https://reviews.llvm.org/D110188