[PATCH] D110340: [llvm-objcopy][docs] Add missing options to the help output and the command guide

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo created this revision.
gbreynoo added reviewers: MaskRay, alexander-shaposhnikov, mmpozulp.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a subscriber: abrachet.
gbreynoo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This change is to keep the help text and command guide of objcopy in tandem.

- In the help output the options `--rename-section` and `--set-section-flags` were missing the flag `exclude`, which is found in the command guide.
- In the command guide the alias `-G` for `--keep-global-symbol` was missing, which is found in the help output.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110340

Files:
  llvm/docs/CommandGuide/llvm-objcopy.rst
  llvm/tools/llvm-objcopy/ObjcopyOpts.td


Index: llvm/tools/llvm-objcopy/ObjcopyOpts.td
===================================================================
--- llvm/tools/llvm-objcopy/ObjcopyOpts.td
+++ llvm/tools/llvm-objcopy/ObjcopyOpts.td
@@ -50,7 +50,8 @@
     : Eq<"rename-section",
          "Renames a section from old to new, optionally with specified flags. "
          "Flags supported for GNU compatibility: alloc, load, noload, "
-         "readonly, debug, code, data, rom, share, contents, merge, strings.">,
+         "readonly, exclude, debug, code, data, rom, share, contents, merge, "
+         "strings.">,
       MetaVarName<"old=new[,flag1,...]">;
 defm redefine_symbol
     : Eq<"redefine-sym", "Change the name of a symbol old to new">,
@@ -82,8 +83,8 @@
 defm set_section_flags
     : Eq<"set-section-flags",
          "Set section flags for a given section. Flags supported for GNU "
-         "compatibility: alloc, load, noload, readonly, debug, code, data, "
-         "rom, share, contents, merge, strings.">,
+         "compatibility: alloc, load, noload, readonly, exclude, debug, code, "
+         "data, rom, share, contents, merge, strings.">,
       MetaVarName<"section=flag1[,flag2,...]">;
 
 def S : Flag<["-"], "S">,
Index: llvm/docs/CommandGuide/llvm-objcopy.rst
===================================================================
--- llvm/docs/CommandGuide/llvm-objcopy.rst
+++ llvm/docs/CommandGuide/llvm-objcopy.rst
@@ -338,7 +338,7 @@
 
  Keep symbols of type `STT_FILE`, even if they would otherwise be stripped.
 
-.. option:: --keep-global-symbol <symbol>
+.. option:: --keep-global-symbol <symbol>, -G
 
  Make all symbols local in the output, except for symbols with the name
  ``<symbol>``. Can be specified multiple times to ignore multiple symbols.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110340.374576.patch
Type: text/x-patch
Size: 1759 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210923/2bf3e443/attachment.bin>