[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

Shivam Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 23 09:14:49 PDT 2021


xgupta accepted this revision.
xgupta added a comment.
This revision is now accepted and ready to land.

In D110260#3018110 <https://reviews.llvm.org/D110260#3018110>, @sgraenitz wrote:

> Thanks @xgupta for your note! The parameter passed to `EPCIndirectionUtils::Create()` in the example was referencing a moved-from value. This caused the segfault. Unfortunately, the examples don't have good test coverage so far.

Yeah we need testcases, now it says

JIT session error: Symbols not found: [ return1 ]
JIT session error: Failed to materialize symbols: { (main, { foo_body }) }
Unable to lazily compile function. Exiting.

Anyways the current patch LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110260/new/

https://reviews.llvm.org/D110260



More information about the llvm-commits mailing list