[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Albion Fung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 23 09:06:41 PDT 2021


Conanap marked 3 inline comments as done.
Conanap added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/test-vector-insert.ll:8
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \
+; RUN:  -mcpu=pwr7 < %s | FileCheck %s
+
----------------
kamaub wrote:
> It seems like this run line is redundant, it produces the same assembly as the big endian specific line above. Maybe the `-mcpu=pwr7` can be moved to the first Little-endian specific run line? That line currently only test the target cpu of the test machine.
good point, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109902/new/

https://reviews.llvm.org/D109902



More information about the llvm-commits mailing list