[PATCH] D110296: [ThinLTO] Don't emit original GUID for locals to distributed indexes

[Wei Mi via Phabricator via llvm-commits]

wmi accepted this revision.
wmi added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/ThinLTO/X86/distributed_indexes.ll:65
+
+; Ensure we don't get a COMBINED_ORIGINAL_NAME record in the distributed index.
+; The BACKEND1-NEXT checks would fail if we did.
----------------
tejohnson wrote:
> wmi wrote:
> > The test is to ensure we don't get COMBINED_ORIGINAL_NAME record. Why the test added BACKEND1-NEXT instead of BACKEND1-NEXT-NOT?
> "-NEXT-NOT" isn't a supported FileCheck suffix. But it doesn't matter, because the -NEXT are very specific and will fail if we get a COMBINED_ORIGINAL_NAME interspersed among them. I confirmed this test fails without the fix, as the COMBINED_ORIGINAL_NAME is in the middle of the "<COMBINED " sequence specified by BACKEND1-NEXT and causes those to fail.
Oh, got it. There is a space after <COMBINED so <COMBINED {{.*}} won't match with COMBINED_ORIGINAL_NAME. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110296/new/

https://reviews.llvm.org/D110296