[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13
+int testdarn_32(void) {
+  return __darn_32();
+}
----------------
Conanap wrote:
> amyk wrote:
> > lei wrote:
> > > Isn't this valid for both 32 and 64bit?
> > > Maybe change one of the run lines above to a 64bit test.
> > I agree. I thought __darn_32 is both 32-bit and 64-bit.
> It is indeed valid for both 32 bit and 64 bit; there is already a runline for 64 bit in the `clang/test/CodeGen/builtins-ppc-xlcompat-darn.c` test case (which includes `__darn_32`, which is why I didn't include it here.
You removed `__darn_32` from that file, so maybe we should add it back. And also, adjust the description of the patch to say that `__darn_32` is available for 32 and 64-bit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110282/new/

https://reviews.llvm.org/D110282