[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

Albion Fung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 23 07:24:04 PDT 2021


Conanap added inline comments.


================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13
+int testdarn_32(void) {
+  return __darn_32();
+}
----------------
lei wrote:
> Isn't this valid for both 32 and 64bit?
> Maybe change one of the run lines above to a 64bit test.
It is indeed valid for both 32 bit and 64 bit; there is already a runline for 64 bit in the `clang/test/CodeGen/builtins-ppc-xlcompat-darn.c` test case (which includes `__darn_32`, which is why I didn't include it here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110282/new/

https://reviews.llvm.org/D110282



More information about the llvm-commits mailing list