[PATCH] D110325: [llvm] Remove conditional checking for macosx 10.5

Ben Langmuir via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 23 07:22:56 PDT 2021


benlangmuir requested changes to this revision.
benlangmuir added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Support/LockFileManager.cpp:38
 
-#if defined(__APPLE__) && defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && (__MAC_OS_X_VERSION_MIN_REQUIRED > 1050)
-#define USE_OSX_GETHOSTUUID 1
-#else
-#define USE_OSX_GETHOSTUUID 0
-#endif
-
-#if USE_OSX_GETHOSTUUID
+#if defined(__APPLE__)
 #include <uuid/uuid.h>
----------------
gethostuuid is not available on all Apple platforms, so we should still check for macOS specifically.  It looks like some other code is using this pattern to check the platform:

```
#if defined(__APPLE__)
#include <TargetConditionals.h>
#if TARGET_OS_OSX
...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110325/new/

https://reviews.llvm.org/D110325



More information about the llvm-commits mailing list