[PATCH] D107162: [lit] Have REQUIRES support the target triple

[Louis Dionne via Phabricator via llvm-commits]

ldionne added a comment.

In D107162#3017984 <https://reviews.llvm.org/D107162#3017984>, @probinson wrote:

> As this patch has had to be reverted due to a completely baffling failure on one bot, we can reopen the debate about how to solve the original problem, which is:  XFAIL and UNSUPPORTED allow triples (with substring handling), but REQUIRES doesn't know about triples at all.
>
> I think adding things into lit itself is a means to avoid redundantly adding the same feature to many subprojects, which carries the attendant risk of adding *almost* the same feature to many subprojects.

Lit could add the feature itself. The main point is that instead of treating the triple specially during boolean evaluation, we'd add a feature consisting of the triple and then handle all features the same way.

> Also, if we're leaning toward doing a bulk syntactic change like you propose, that should be brought up on the dev lists first to get broader exposure and buy-in.

I was just talking about libc++'s experience -- we don't really have to rename everything if people think it causes too much churn. But using `target=<xxx>` instead of just `<xxx>` has the benefit that

1. it's clear that we're talking about a property of the target, not a property of the host, and
2. one can't confuse the triple-as-specially-handled-by-lit and the triple-as-a-normal-lit-feature during the transitional period where both exist


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107162/new/

https://reviews.llvm.org/D107162