[PATCH] D109890: Flang OpenMP Report Plugin

[Ivan Zhechev via Phabricator via llvm-commits]

ijan1 added inline comments.


================
Comment at: flang/examples/flang-omp-report-plugin/flang-omp-report-support.h:30
+      : clause{std::get<0>(p)}, clauseDetails{std::get<1>(p)} {}
+  friend bool operator<(const ClauseInfo &a, const ClauseInfo &b) {
+    return a.clause < b.clause;
----------------
awarzynski wrote:
> Hm, everything is `public` here. Do we need `friend`? Some in other places.
To my understanding, `friend` is used because class methods take an implicit `this` parameter. So, when you're overloading operator methods, there's 3 parameters being passed, which is illegal. I've moved the definitions out of the class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109890/new/

https://reviews.llvm.org/D109890