[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

[Lucas Prates via Phabricator via llvm-commits]

pratlucas added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:3299
 static void setRequiredFeatureString(FeatureBitset FBS, std::string &Str) {
   if (FBS[AArch64::HasV8_1aOps])
     Str += "ARMv8.1a";
----------------
As features can now depend on `HasV8_0aOps`, does it make sense to cover it here?


================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1567-1571
+    Reg = AArch64SysReg::lookupSysRegByName("TTBR0_EL2");
+    if (Reg && Reg->Readable && Reg->haveFeatures(STI.getFeatureBits())) {
+      O << Reg->Name;
+      return;
+    }
----------------
Nit: Maybe extract this block to a function as it's used a few times.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110065/new/

https://reviews.llvm.org/D110065