[PATCH] D109713: [AutoFDO][llvm-profgen] Report zero count for unexecuted part of function code

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:153
+
+    BoundaryPoint() = default;
+
----------------
wenlei wrote:
> curious why we need this? 
uh, I just wrote it unintentionally, it can be removed.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:226
   uint64_t BeginAddress = UINT64_MAX;
+  int ZeroRangeDepth = 0;
   int Count = 0;
----------------
wenlei wrote:
> Since we only add zero ranges for functions, there won't be any overlapping zero range and the Depth is going to be either 0 or 1, right? 
Yes, in our case, function range apparently won't overlap and also there is no zero count in the sample.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109713/new/

https://reviews.llvm.org/D109713