[PATCH] D110188: [compiler-rt][profile] Add padding after binary IDs

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 22 16:41:40 PDT 2021


phosek added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformLinux.c:171
+ */
+static int WriteBinaryIdsWithPadding(ProfDataWriter *Writer, const ElfW(Nhdr) * Note,
+                                     const ElfW(Nhdr) * NotesEnd) {
----------------
Since `WriteBinaryIds` isn't used from anywhere else, I'd just combine the two functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110188/new/

https://reviews.llvm.org/D110188



More information about the llvm-commits mailing list