[PATCH] D110277: [compiler-rt][profile] Do not emit binary IDs for corrupted-profile.c test

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 22 13:23:53 PDT 2021


aeubanks added a comment.

In D110277#3016320 <https://reviews.llvm.org/D110277#3016320>, @leonardchan wrote:

> In D110277#3016205 <https://reviews.llvm.org/D110277#3016205>, @aeubanks wrote:
>
>> does not having the build id change the header size?
>
> No, the header will still contain the section for the build ID size. It's just that the value will be zero.

I'm not understanding the description then. Why would the offset calculation be wrong if we're not changing the size of anything?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110277/new/

https://reviews.llvm.org/D110277



More information about the llvm-commits mailing list