[PATCH] D110283: [ADT] Add trailing comma on TYPED_TEST_SUITE

Luke Benes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 22 12:52:57 PDT 2021


lbenes created this revision.
lbenes added a reviewer: arames.
lbenes requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This avoids a -pedantic warning:
warning: ISO C++11 requires at least one argument for the "..." in a variadic macro

See also google/googletest#2271


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110283

Files:
  llvm/unittests/ADT/SequenceTest.cpp


Index: llvm/unittests/ADT/SequenceTest.cpp
===================================================================
--- llvm/unittests/ADT/SequenceTest.cpp
+++ llvm/unittests/ADT/SequenceTest.cpp
@@ -35,7 +35,7 @@
                                      >;
 
 template <class T> class StrongIntTest : public testing::Test {};
-TYPED_TEST_SUITE(StrongIntTest, IntegralTypes);
+TYPED_TEST_SUITE(StrongIntTest, IntegralTypes, );
 TYPED_TEST(StrongIntTest, Operations) {
   using T = TypeParam;
   auto Max = std::numeric_limits<T>::max();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110283.374331.patch
Type: text/x-patch
Size: 529 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210922/1f24b116/attachment.bin>


More information about the llvm-commits mailing list