[PATCH] D105278: [demangle] Support for ISO/IEC TS 18661 binary floating point type

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 22 12:42:25 PDT 2021


ldionne added a comment.

In D105278#3016057 <https://reviews.llvm.org/D105278#3016057>, @SjoerdMeijer wrote:

> Sorry, just dipping in, and I am not familiar with this code, but do we need to add tests?

The tests are in `test_demangle.pass.cpp` but you can't see them because Phab uploads that file as a binary file, since it's too large. I'm trusting the author that their tests are sufficient (I planned on post-commit reviewing that).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105278/new/

https://reviews.llvm.org/D105278



More information about the llvm-commits mailing list