[PATCH] D110100: [NFCI][CodeGen, AArch64] Fix inconsistent TargetCostKind types.

Daniil Fukalov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 22 10:17:26 PDT 2021


dfukalov added inline comments.


================
Comment at: llvm/lib/CodeGen/InterleavedLoadCombinePass.cpp:1133
   InstructionCost InterleavedCost;
   InstructionCost InstructionCost = 0;
 
----------------
RKSimon wrote:
> Would it make sense to add a common CostKind variable here and update all the getCost calls to use that? We already do something similar in SLP.
> ```
> TTI::TargetCostKind CostKind = TTI::TCK_SizeAndLatency;
> ```
Good point, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110100/new/

https://reviews.llvm.org/D110100



More information about the llvm-commits mailing list