[PATCH] D96854: [CodeExtractor] Enable partial aggregate arguments

[Vedant Kumar via Phabricator via llvm-commits]

vsk added subscribers: paquette, AndrewLitteken, jroelofs.
vsk added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:833
   std::vector<Type *> paramTy;
+  std::vector<Type *> ScalarParamTy;
+  std::vector<Type *> AggParamTy;
----------------
I notice there's a `paramTy = ScalarParamTy`: can we delete `paramTy` entirely? Having two copies of the same thing creates a risk of the copies diverging, adding complexity.


================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:861
+      "Number of scalar and aggregate params does not match inputs, outputs");
+
+  paramTy = ScalarParamTy;
----------------
Suggest - `assert(StructValues.empty() || AggregateArgs && "StructValues updated for arg structs only")`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96854/new/

https://reviews.llvm.org/D96854